Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a variety of typos #1306

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Fixed a variety of typos #1306

merged 1 commit into from
Apr 14, 2021

Conversation

kolbe
Copy link
Contributor

@kolbe kolbe commented Apr 14, 2021

What problem does this PR solve?

I noticed quite a few typos and spelling/grammar problems in errors and other messages.

What is changed and how it works?

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Documentation updates may be needed in order to make sure the output of tiup matches example output in the docs.

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Apr 14, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove April 14, 2021 02:04
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2021
@lucklove
Copy link
Member

Thanks, kolbe.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e82a388

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2021
@codecov-io
Copy link

Codecov Report

Merging #1306 (baf2945) into master (3366472) will increase coverage by 26.53%.
The diff coverage is 53.84%.

❗ Current head baf2945 differs from pull request most recent head e82a388. Consider uploading reports for the commit e82a388 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1306       +/-   ##
===========================================
+ Coverage   26.25%   52.79%   +26.53%     
===========================================
  Files         263      289       +26     
  Lines       18947    20814     +1867     
===========================================
+ Hits         4975    10989     +6014     
+ Misses      13201     8072     -5129     
- Partials      771     1753      +982     
Flag Coverage Δ
cluster 38.37% <0.00%> (?)
dm 26.54% <0.00%> (?)
integrate 47.08% <53.84%> (+30.58%) ⬆️
playground 24.17% <0.00%> (?)
tiup 16.49% <53.84%> (ø)
unittest 22.76% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/environment/env.go 58.33% <0.00%> (+2.50%) ⬆️
pkg/repository/mirror.go 39.84% <0.00%> (+0.39%) ⬆️
cmd/mirror.go 48.68% <87.50%> (ø)
pkg/cluster/operation/download.go 36.84% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
pkg/cluster/flags/debug.go 100.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
pkg/cluster/operation/action.go 63.71% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3366472...e82a388. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 3a1296b into pingcap:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants