-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: add --comments option to the mysql client connection tips #1323
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 84ce2f7
|
@tangenta: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
==========================================
+ Coverage 26.26% 31.14% +4.88%
==========================================
Files 263 275 +12
Lines 19005 19429 +424
==========================================
+ Hits 4991 6052 +1061
+ Misses 13240 12431 -809
- Partials 774 946 +172
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
pingcap/tidb#24176 (comment)
What is changed and how it works?
Add the
--comments
option to the mysql client connection tips.Check List
Tests
Code changes
NA
Side effects
NA
Related changes
NA
Release notes: