Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix and optimize os version check #1336

Merged
merged 5 commits into from
May 6, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1332 and add warning to Debian/Ubuntu users.

Our components should be working on recent Debian and Ubuntu systems, we have some development servers running Debian and Ubuntu systems and are working well, but we don't yet have them fully tested, our full test suits are only run on CentOS 7 as of now.

What is changed and how it works?

  • Fix version check for some RHEL systems
  • Add warnings for Debian and Ubuntu systems
  • Check versions of Debian and Ubuntu systems and report error for very old releases

The change does not matters that much as the check process is optional for users trying to deploy a cluster.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: fix and optimize os version check

@AstroProfundis AstroProfundis added this to the v1.4.3 milestone Apr 28, 2021
@AstroProfundis AstroProfundis requested a review from lucklove April 28, 2021 04:31
@AstroProfundis AstroProfundis self-assigned this Apr 28, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2021

Codecov Report

Merging #1336 (93fff2a) into master (54ac4d5) will not change coverage.
The diff coverage is n/a.

❗ Current head 93fff2a differs from pull request most recent head b4938c6. Consider uploading reports for the commit b4938c6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1336   +/-   ##
=======================================
  Coverage   15.79%   15.79%           
=======================================
  Files         146      146           
  Lines       12133    12133           
=======================================
  Hits         1917     1917           
  Misses       9721     9721           
  Partials      495      495           
Flag Coverage Δ
integrate 15.79% <ø> (ø)
tiup 15.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ac4d5...b4938c6. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2021
@lucklove
Copy link
Member

lucklove commented May 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5fd4a48

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2021
@ti-chi-bot ti-chi-bot merged commit a3b54e8 into pingcap:master May 6, 2021
@AstroProfundis AstroProfundis deleted the fix-check-os branch May 6, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check system info throws an error “os vendor rhel not supported”
4 participants