-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix and optimize os version check #1336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
=======================================
Coverage 15.79% 15.79%
=======================================
Files 146 146
Lines 12133 12133
=======================================
Hits 1917 1917
Misses 9721 9721
Partials 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5fd4a48
|
What problem does this PR solve?
Fix #1332 and add warning to Debian/Ubuntu users.
Our components should be working on recent Debian and Ubuntu systems, we have some development servers running Debian and Ubuntu systems and are working well, but we don't yet have them fully tested, our full test suits are only run on CentOS 7 as of now.
What is changed and how it works?
The change does not matters that much as the
check
process is optional for users trying to deploy a cluster.Check List
Tests
Related changes
Release notes: