Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: add simple report for playground #1353

Merged
merged 3 commits into from
May 10, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Add simple telemetry data report for tiup-playground

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch

Release notes:

telemetry: add simple report for playground

@AstroProfundis AstroProfundis added the component/playground Issues about the tiup-playground component label May 8, 2021
@AstroProfundis AstroProfundis added this to the v1.4.3 milestone May 8, 2021
@AstroProfundis AstroProfundis requested a review from lucklove May 8, 2021 09:31
@AstroProfundis AstroProfundis self-assigned this May 8, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #1353 (28b4cca) into master (8aa6c67) will increase coverage by 28.58%.
The diff coverage is 20.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1353       +/-   ##
===========================================
+ Coverage   25.95%   54.53%   +28.58%     
===========================================
  Files         265      290       +25     
  Lines       20029    22294     +2265     
===========================================
+ Hits         5198    12158     +6960     
+ Misses      14035     8233     -5802     
- Partials      796     1903     +1107     
Flag Coverage Δ
cluster 41.91% <3.02%> (?)
dm 24.75% <2.02%> (?)
integrate 49.07% <20.53%> (+33.07%) ⬆️
playground 13.78% <19.24%> (?)
tiup 15.52% <3.02%> (-0.48%) ⬇️
unittest 21.73% <1.78%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/root.go 72.66% <0.00%> (-2.17%) ⬇️
components/cluster/command/deploy.go 65.11% <ø> (+34.88%) ⬆️
components/playground/instance/instance.go 45.45% <ø> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
pkg/telemetry/report.pb.go 0.94% <2.08%> (-0.07%) ⬇️
components/playground/main.go 60.52% <46.83%> (+56.50%) ⬆️
components/playground/playground.go 48.40% <61.53%> (+48.40%) ⬆️
pkg/telemetry/scrub.go 72.54% <62.50%> (-3.01%) ⬇️
components/cluster/command/root.go 42.10% <100.00%> (+17.49%) ⬆️
components/playground/command.go 79.59% <100.00%> (+79.59%) ⬆️
... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa6c67...28b4cca. Read the comment docs.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28b4cca

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@ti-chi-bot ti-chi-bot merged commit 6ee8abc into pingcap:master May 10, 2021
@AstroProfundis AstroProfundis deleted the playground-telemetry branch May 10, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/playground Issues about the tiup-playground component size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants