Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: allow scale-in when there is no tispark master node #1363

Merged
merged 1 commit into from
May 13, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1354

What is changed and how it works?

It's reasonable to scale in the remaining tispark worker node in such situation

Check List

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: allow scale-in when there is no tispark master node

@AstroProfundis AstroProfundis added the type/enhancement Categorizes issue or PR as related to an enhancement. label May 13, 2021
@AstroProfundis AstroProfundis added this to the v1.4.4 milestone May 13, 2021
@AstroProfundis AstroProfundis requested a review from lucklove May 13, 2021 07:44
@AstroProfundis AstroProfundis self-assigned this May 13, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #1363 (6307a43) into master (b1b03c9) will increase coverage by 29.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1363       +/-   ##
===========================================
+ Coverage   25.38%   54.43%   +29.05%     
===========================================
  Files         265      290       +25     
  Lines       20462    22346     +1884     
===========================================
+ Hits         5194    12165     +6971     
+ Misses      14471     8275     -6196     
- Partials      797     1906     +1109     
Flag Coverage Δ
cluster 41.81% <75.00%> (?)
dm 24.76% <75.00%> (?)
integrate 48.98% <75.00%> (+33.46%) ⬆️
playground 13.78% <ø> (?)
tiup 15.52% <ø> (ø)
unittest 21.68% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/scale_in.go 58.69% <75.00%> (+58.69%) ⬆️
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 78.26% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
pkg/cluster/operation/destroy.go 56.61% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
pkg/cluster/operation/check.go 46.70% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b03c9...6307a43. Read the comment docs.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6307a43

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2021
@ti-chi-bot ti-chi-bot merged commit dd6b818 into pingcap:master May 13, 2021
@AstroProfundis AstroProfundis deleted the issue-1354 branch May 13, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: there must be a Spark master node if you want to use the TiSpark component
4 participants