-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't check labels when user enable placement-rule #1378
Conversation
From https://docs.pingcap.com/tidb/stable/configure-placement-rules#scenario-4-add-two-follower-replicas-for-a-table-in-the-beijing-node-with-high-performance-disks: > After enabling Placement Rules, the previously configured max-replicas and location-labels no longer take effect. To adjust the replica policy, use the interface related to Placement Rules. Fix pingcap#1371
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
===========================================
+ Coverage 25.33% 50.06% +24.72%
===========================================
Files 265 290 +25
Lines 20515 22400 +1885
===========================================
+ Hits 5198 11214 +6016
+ Misses 14517 9392 -5125
- Partials 800 1794 +994
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: aa93117
|
@lucklove: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
From https://docs.pingcap.com/tidb/stable/configure-placement-rules:
Fix #1371
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: