Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix wrong SELINUX disabling config #1383

Merged
merged 1 commit into from
May 24, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1364

Code changes

  • Has persistent data change

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: fix wrong SELINUX disabling config

@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label May 24, 2021
@AstroProfundis AstroProfundis added this to the v1.4.4 milestone May 24, 2021
@AstroProfundis AstroProfundis requested a review from lucklove May 24, 2021 09:10
@AstroProfundis AstroProfundis self-assigned this May 24, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #1383 (d54d240) into master (98eac18) will increase coverage by 23.81%.
The diff coverage is 0.00%.

❗ Current head d54d240 differs from pull request most recent head e01bee3. Consider uploading reports for the commit e01bee3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1383       +/-   ##
===========================================
+ Coverage   25.33%   49.14%   +23.81%     
===========================================
  Files         265      290       +25     
  Lines       20517    22400     +1883     
===========================================
+ Hits         5198    11009     +5811     
+ Misses      14519     9643     -4876     
- Partials      800     1748      +948     
Flag Coverage Δ
cluster 33.09% <0.00%> (?)
dm 24.57% <0.00%> (?)
integrate 43.52% <0.00%> (+27.95%) ⬆️
playground 13.80% <ø> (?)
tiup 15.57% <ø> (ø)
unittest 21.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/check.go 0.00% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 23.63% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/instance.go 45.45% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
pkg/cluster/operation/destroy.go 52.20% <0.00%> (ø)
pkg/cluster/operation/systemd.go 0.00% <0.00%> (ø)
pkg/cluster/operation/download.go 36.84% <0.00%> (ø)
components/playground/instance/process.go 81.39% <0.00%> (ø)
... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98eac18...e01bee3. Read the comment docs.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e01bee3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2021
@ti-chi-bot ti-chi-bot merged commit fdadd94 into pingcap:master May 24, 2021
@AstroProfundis AstroProfundis deleted the selinux branch May 26, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiup check --apply modify
4 participants