-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: check, deploy support use ssh-agent instead of identity-file #1416
Conversation
/run-all-tests |
c2e6821
to
130d991
Compare
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
- Coverage 25.32% 24.04% -1.28%
==========================================
Files 266 226 -40
Lines 20625 18434 -2191
==========================================
- Hits 5223 4433 -790
+ Misses 14599 13169 -1430
- Partials 803 832 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@AstroProfundis PTAL |
IdentityFile: identityFilePath, | ||
IdentityFilePassphrase: passphrase, | ||
}, nil | ||
return &SSHConnectionProps{}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is sshAuthSock
used in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSH_AUTH_SOCK will be used in https://github.com/appleboy/easyssh-proxy/blob/master/easyssh.go#L147-L149, our previous code just checks this socket file exists and valid.
Co-authored-by: Allen Zhong <allen@moe.cat>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 547f5b9
|
What problem does this PR solve?
implement #1393
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: