Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pd and dashboard address display issue in tiup-playground #1428

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

iosmanthus
Copy link
Contributor

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

In tidb mode, if the tidb starts then we can say the PDs must start. However, when in tikv-slim mode, there is an issue that tiup-playground won't print any information about PD, because it won't wait for any instance of PDs to really start.

What is changed and how it works?

  1. Print dashboard's address only when there are some TiDB instances.
  2. Always print PD's address.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
Starting component `playground`: /home/iosmanthus/.tiup/components/playground/v1.5.1/tiup-playground --mode tikv-slim
Using the version v5.0.2 for version constraint "".

If you'd like to use a TiDB version other than v5.0.2, cancel and retry with the following arguments:
    Specify version manually:   tiup playground <version>
    Specify version range:      tiup playground ^5
    The nightly version:        tiup playground nightly

Playground Bootstrapping...
Start pd instance
Start tikv instance
PD client endpoints: [127.0.0.1:2379]
To view the Prometheus: http://127.0.0.1:39625
To view the Grafana: http://127.0.0.1:3000

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release notes:

display PD client endpoints in playground

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@ti-chi-bot ti-chi-bot requested review from lonng and lucklove June 16, 2021 07:28
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2021
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #1428 (8cfd38e) into master (4e8f168) will increase coverage by 4.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   25.40%   30.04%   +4.64%     
==========================================
  Files         264      276      +12     
  Lines       20631    21057     +426     
==========================================
+ Hits         5241     6327    +1086     
+ Misses      14586    13752     -834     
- Partials      804      978     +174     
Flag Coverage Δ
integrate 21.74% <100.00%> (+6.25%) ⬆️
playground 13.76% <100.00%> (?)
tiup 15.48% <ø> (ø)
unittest 21.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 48.55% <100.00%> (+48.55%) ⬆️
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/tiflash.go 59.09% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
components/playground/instance/instance.go 45.45% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 81.39% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8f168...8cfd38e. Read the comment docs.

@iosmanthus
Copy link
Contributor Author

@AstroProfundis PTAL

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2021
@AstroProfundis AstroProfundis added this to the v1.5.2 milestone Jun 16, 2021
@AstroProfundis AstroProfundis added the component/playground Issues about the tiup-playground component label Jun 16, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cfd38e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@ti-chi-bot ti-chi-bot merged commit 89ebe5a into pingcap:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/playground Issues about the tiup-playground component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants