-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pd and dashboard address display issue in tiup-playground
#1428
fix pd and dashboard address display issue in tiup-playground
#1428
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
+ Coverage 25.40% 30.04% +4.64%
==========================================
Files 264 276 +12
Lines 20631 21057 +426
==========================================
+ Hits 5241 6327 +1086
+ Misses 14586 13752 -834
- Partials 804 978 +174
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@AstroProfundis PTAL |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8cfd38e
|
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
In
tidb
mode, if thetidb
starts then we can say the PDs must start. However, when intikv-slim
mode, there is an issue thattiup-playground
won't print any information about PD, because it won't wait for any instance of PDs to really start.What is changed and how it works?
Check List
Tests
Side effects
Related changes
Release notes: