Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update dependencies #1433

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix error when running new version of insight, and also update some other depends

What is changed and how it works?

Use the patched version of eassy-proxy.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.5.2 milestone Jun 18, 2021
@AstroProfundis AstroProfundis requested a review from lucklove June 18, 2021 09:39
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #1433 (f5c3e85) into master (26996ef) will increase coverage by 19.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1433       +/-   ##
===========================================
+ Coverage   25.23%   44.57%   +19.34%     
===========================================
  Files         264      288       +24     
  Lines       20743    22592     +1849     
===========================================
+ Hits         5235    10071     +4836     
+ Misses      14705    10896     -3809     
- Partials      803     1625      +822     
Flag Coverage Δ
cluster 32.39% <ø> (?)
integrate 39.26% <ø> (+23.84%) ⬆️
playground 13.70% <ø> (?)
tiup 15.42% <ø> (ø)
unittest 21.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/action.go 48.52% <0.00%> (ø)
pkg/logger/debug.go 16.66% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 34.78% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
pkg/cluster/operation/download.go 36.84% <0.00%> (ø)
components/playground/instance/tiflash.go 59.09% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/cluster/operation/systemd.go 0.00% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 0.90% <0.00%> (ø)
... and 153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26996ef...f5c3e85. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f5c3e85

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@ti-chi-bot ti-chi-bot merged commit 7b0c5e1 into pingcap:master Jun 21, 2021
@AstroProfundis AstroProfundis deleted the update-depends branch June 21, 2021 03:49
AstroProfundis added a commit that referenced this pull request Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants