-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/ssh: don't quote ssh options #1469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
+ Coverage 24.85% 32.86% +8.01%
==========================================
Files 267 228 -39
Lines 21267 18493 -2774
==========================================
+ Hits 5285 6078 +793
+ Misses 15175 11350 -3825
- Partials 807 1065 +258
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
The unit test is failing. |
Seems there is something wrong of the tiup-mirror, please take a look at #1436 (comment) |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 04bb33b
|
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: