Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version 1.5.3 #1487

Merged
merged 1 commit into from
Jul 14, 2021
Merged

bump version 1.5.3 #1487

merged 1 commit into from
Jul 14, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

bump v1.5.3

@AstroProfundis AstroProfundis added this to the v1.5.3 milestone Jul 14, 2021
@AstroProfundis AstroProfundis requested a review from lucklove July 14, 2021 08:01
@AstroProfundis AstroProfundis self-assigned this Jul 14, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1487 (214de58) into master (de5c898) will decrease coverage by 3.45%.
The diff coverage is n/a.

❗ Current head 214de58 differs from pull request most recent head d275df0. Consider uploading reports for the commit d275df0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
- Coverage   26.28%   22.82%   -3.46%     
==========================================
  Files         267      228      -39     
  Lines       23823    22002    -1821     
==========================================
- Hits         6261     5023    -1238     
+ Misses      16739    16410     -329     
+ Partials      823      569     -254     
Flag Coverage Δ
integrate ?
tiup ?
unittest 22.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (-100.00%) ⬇️
cmd/env.go 27.77% <0.00%> (-66.67%) ⬇️
pkg/utils/args.go 0.00% <0.00%> (-50.00%) ⬇️
cmd/root.go 24.47% <0.00%> (-48.96%) ⬇️
pkg/repository/v1manifest/repo.go 0.00% <0.00%> (-47.50%) ⬇️
cmd/uninstall.go 30.88% <0.00%> (-44.12%) ⬇️
pkg/repository/mirror.go 6.36% <0.00%> (-36.05%) ⬇️
pkg/utils/http_client.go 0.00% <0.00%> (-35.19%) ⬇️
pkg/utils/retry.go 0.00% <0.00%> (-34.89%) ⬇️
pkg/utils/sha.go 0.00% <0.00%> (-34.79%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5c898...d275df0. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d275df0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2021
@ti-chi-bot ti-chi-bot merged commit fcb0429 into pingcap:master Jul 14, 2021
@AstroProfundis AstroProfundis deleted the bump-v1.5.3 branch July 14, 2021 08:45
AstroProfundis added a commit that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants