Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: allow editing of lernel_config in tiflash #1494

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1493

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis added the component/cluster Issues about the tiup-cluster component label Jul 21, 2021
@AstroProfundis AstroProfundis added this to the v1.5.4 milestone Jul 21, 2021
@AstroProfundis AstroProfundis requested a review from lucklove July 21, 2021 03:27
@AstroProfundis AstroProfundis self-assigned this Jul 21, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #1494 (348b11e) into master (600edd2) will increase coverage by 4.45%.
The diff coverage is n/a.

❗ Current head 348b11e differs from pull request most recent head f9c46ba. Consider uploading reports for the commit f9c46ba to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1494      +/-   ##
==========================================
+ Coverage   26.26%   30.72%   +4.45%     
==========================================
  Files         267      279      +12     
  Lines       23834    24328     +494     
==========================================
+ Hits         6261     7475    +1214     
+ Misses      16750    15860     -890     
- Partials      823      993     +170     
Flag Coverage Δ
integrate 21.88% <ø> (+5.68%) ⬆️
playground 13.66% <ø> (?)
tiup 16.20% <ø> (ø)
unittest 22.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/tiflash.go 53.47% <ø> (ø)
components/playground/instance/process.go 84.90% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/pd.go 75.00% <0.00%> (ø)
components/playground/instance/instance.go 51.72% <0.00%> (ø)
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600edd2...f9c46ba. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb7c177

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit 783faee into pingcap:master Jul 23, 2021
@AstroProfundis AstroProfundis deleted the edit-config branch July 23, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edit-config support to modify tiflash-learner file
4 participants