Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: ignore version check error in some cases #1495

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Introduced in #1325, hopefully fix #1481

What is changed and how it works?

If the user has any of the binpath arguments set, we assume the user is a developer testing their latest code, so use the latest possible version for other components if needed. The version is resolved with linux-amd64 as platform as it's the platform with every released versions available, and ignore the real platform the user is using. This, however, may cause issue if the user didn't specify binpath for all components used, and the latest version is not available for those components in the user's platform. In such cases, the user should either specify binpath for all the remaining components as well, or set a version that available for those components.

Check List

Tests

I have not tested this PR as I don't have access to any Apple M1 device, on which the issue is reproducible.

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis added the component/playground Issues about the tiup-playground component label Jul 21, 2021
@AstroProfundis AstroProfundis requested a review from lucklove July 21, 2021 05:57
@AstroProfundis AstroProfundis self-assigned this Jul 21, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #1495 (8267c28) into master (fcb0429) will increase coverage by 29.76%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1495       +/-   ##
===========================================
+ Coverage   26.28%   56.04%   +29.76%     
===========================================
  Files         267      292       +25     
  Lines       23823    25967     +2144     
===========================================
+ Hits         6261    14554     +8293     
+ Misses      16739     9412     -7327     
- Partials      823     2001     +1178     
Flag Coverage Δ
cluster 43.80% <0.00%> (?)
dm 26.48% <0.00%> (?)
integrate 50.64% <0.00%> (+34.43%) ⬆️
playground 13.66% <0.00%> (?)
tiup 16.20% <0.00%> (-0.01%) ⬇️
unittest 22.81% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/main.go 45.94% <0.00%> (+43.38%) ⬆️
components/playground/playground.go 49.22% <ø> (+49.22%) ⬆️
pkg/repository/v1_repository.go 61.58% <0.00%> (+0.99%) ⬆️
pkg/cluster/operation/check.go 48.58% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 60.22% <0.00%> (ø)
components/playground/instance/instance.go 51.72% <0.00%> (ø)
components/playground/instance/pd.go 75.00% <0.00%> (ø)
components/playground/instance/process.go 84.90% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb0429...8267c28. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2021
@lucklove lucklove merged commit 0f790d6 into pingcap:master Jul 22, 2021
@AstroProfundis AstroProfundis deleted the fix-ver-check branch September 1, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/playground Issues about the tiup-playground component size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be better bypass platform check when user provides binary
4 participants