Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embed examples #1502

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Deploying monitor agents in tiup-dm is supported in a slightly different way as in tiup-cluster, but it was not documented anywhere. This causes issues like #1501

What is changed and how it works?

Add example of specifying monitor agent configs in the full topology example of tiup-dm, which can be printed with tiup-dm template --full. The section is commented as the default behavior is not to deploy those agents to avoid conflict with tidb clusters deployed by tiup-cluster.

Also adjusted the directory layout of embed, move examples to a dedicated path.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Jul 28, 2021
@AstroProfundis AstroProfundis requested a review from lucklove July 28, 2021 03:47
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Jul 28, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2021

Codecov Report

Merging #1502 (f28936f) into master (ef79639) will increase coverage by 29.95%.
The diff coverage is 87.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1502       +/-   ##
===========================================
+ Coverage   26.17%   56.12%   +29.95%     
===========================================
  Files         267      292       +25     
  Lines       23939    26074     +2135     
===========================================
+ Hits         6265    14634     +8369     
+ Misses      16850     9431     -7419     
- Partials      824     2009     +1185     
Flag Coverage Δ
cluster 43.96% <77.41%> (?)
dm 26.36% <48.38%> (?)
integrate 50.73% <81.81%> (+34.61%) ⬆️
playground 13.79% <0.00%> (?)
tiup 16.11% <0.00%> (-0.01%) ⬇️
unittest 22.72% <17.39%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/template.go 28.12% <0.00%> (ø)
components/dm/command/template.go 41.17% <0.00%> (ø)
embed/embed.go 100.00% <100.00%> (ø)
pkg/cluster/template/config/alertmanager.go 64.70% <100.00%> (+64.70%) ⬆️
pkg/cluster/template/config/blackbox.go 65.21% <100.00%> (+65.21%) ⬆️
pkg/cluster/template/config/config.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/cluster/template/config/dashboard.go 65.21% <100.00%> (+65.21%) ⬆️
pkg/cluster/template/config/datasource.go 70.37% <100.00%> (+70.37%) ⬆️
pkg/cluster/template/config/grafana.go 80.95% <100.00%> (+80.95%) ⬆️
pkg/cluster/template/config/prometheus.go 75.78% <100.00%> (+75.78%) ⬆️
... and 238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef79639...f28936f. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ad3357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants