Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Set terminal title #1506

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 30, 2021

What problem does this PR solve?

This sets the terminal title to "TiUP Playground: " where name
is the last part of the datadir. With tiup -T foobar playground etc.
this name can be set. Also tiup client uses the same names.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

TiUP Playground now sets the terminal title to the name of the playground

This sets the terminal title to "TiUP Playground: <name>" where name
is the last part of the datadir. With `tiup -T foobar playground` etc.
this name can be set. Also `tiup client` uses the same names.
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Jul 30, 2021

This needs to be tested with a few terminal emulators on macOS and Linux for compatibility issues.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #1506 (587633d) into master (783faee) will increase coverage by 4.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   26.26%   30.72%   +4.45%     
==========================================
  Files         267      279      +12     
  Lines       23834    24420     +586     
==========================================
+ Hits         6261     7503    +1242     
+ Misses      16750    15920     -830     
- Partials      823      997     +174     
Flag Coverage Δ
integrate 21.93% <100.00%> (+5.72%) ⬆️
playground 13.76% <100.00%> (?)
tiup 16.10% <ø> (-0.10%) ⬇️
unittest 22.72% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/main.go 46.38% <100.00%> (+43.94%) ⬆️
pkg/cluster/api/binlog.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/pd.go 75.00% <0.00%> (ø)
components/playground/instance/tidb.go 83.78% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/process.go 84.90% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 83.33% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537aacb...587633d. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Aug 2, 2021
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Works for me on ArchLinux connecting to an Debian VM via SSH.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 587633d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2021
@ti-chi-bot ti-chi-bot merged commit 35abe88 into pingcap:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants