Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for sudo command #1515 #1516

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Aug 12, 2021

What problem does this PR solve?

sudo error when use devtoolset

[root@ip-172-16-5-33 ~]# /opt/rh/devtoolset-8/root/usr/bin/sudo -l
/var/tmp/sclk5fzvz: line 8: -l: command not found

fix: #1515

What is changed and how it works?

use /usr/bin/sudo insted of sudo

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove August 12, 2021 04:02
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2021
@AstroProfundis
Copy link
Contributor

There are also sudos in pkg/cluster/executor/ssh.go

@nexustar nexustar force-pushed the absolute_sudo_path branch from d71b6db to 244b96b Compare August 12, 2021 04:35
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #1516 (c8a1e70) into master (5ef4728) will increase coverage by 9.20%.
The diff coverage is 16.66%.

❗ Current head c8a1e70 differs from pull request most recent head 244b96b. Consider uploading reports for the commit 244b96b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   26.26%   35.46%   +9.20%     
==========================================
  Files         267      258       -9     
  Lines       24048    22699    -1349     
==========================================
+ Hits         6317     8051    +1734     
+ Misses      16908    13464    -3444     
- Partials      823     1184     +361     
Flag Coverage Δ
cluster 31.65% <16.66%> (?)
dm 24.71% <16.66%> (?)
integrate 35.46% <16.66%> (+19.42%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/executor/local.go 0.00% <0.00%> (-56.95%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/executor/ssh.go 24.65% <50.00%> (+11.16%) ⬆️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-83.15%) ⬇️
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef4728...244b96b. Read the comment docs.

@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 244b96b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@ti-chi-bot ti-chi-bot merged commit ddceaff into pingcap:master Aug 12, 2021
@nexustar nexustar deleted the absolute_sudo_path branch August 16, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use absolute path for sudo command
5 participants