Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: reverse the order of audit log list #1538

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1525

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@AstroProfundis AstroProfundis self-assigned this Aug 30, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #1538 (a8f7871) into master (93b0211) will increase coverage by 27.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1538       +/-   ##
===========================================
+ Coverage   26.27%   53.51%   +27.24%     
===========================================
  Files         267      291       +24     
  Lines       24069    26196     +2127     
===========================================
+ Hits         6323    14020     +7697     
+ Misses      16924    10233     -6691     
- Partials      822     1943     +1121     
Flag Coverage Δ
cluster 44.00% <100.00%> (?)
integrate 49.18% <100.00%> (+33.10%) ⬆️
playground 13.84% <ø> (?)
tiup 16.08% <ø> (ø)
unittest 22.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/audit/audit.go 68.42% <100.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
pkg/cluster/operation/systemd.go 75.00% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/playground/instance/tidb.go 84.61% <0.00%> (ø)
pkg/cluster/operation/operation.go 78.57% <0.00%> (ø)
pkg/cluster/operation/download.go 40.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
... and 186 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b0211...a8f7871. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2021
@AstroProfundis AstroProfundis added this to the v1.5.6 milestone Aug 31, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a8f7871

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2021
@ti-chi-bot ti-chi-bot merged commit 1da79b6 into pingcap:master Aug 31, 2021
@AstroProfundis AstroProfundis deleted the sort-audit branch August 31, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup-cluster audit according to time
4 participants