Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dm test #1540

Merged
merged 1 commit into from
Aug 31, 2021
Merged

fix dm test #1540

merged 1 commit into from
Aug 31, 2021

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

dm changed json name pingcap/dm@8325f1b

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from 9547 and lucklove August 30, 2021 11:07
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #1540 (c3ab37b) into master (090b201) will increase coverage by 17.74%.
The diff coverage is n/a.

❗ Current head c3ab37b differs from pull request most recent head 6b2a804. Consider uploading reports for the commit 6b2a804 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1540       +/-   ##
===========================================
+ Coverage   26.27%   44.01%   +17.74%     
===========================================
  Files         267      228       -39     
  Lines       24069    20987     -3082     
===========================================
+ Hits         6323     9237     +2914     
+ Misses      16924    10385     -6539     
- Partials      822     1365      +543     
Flag Coverage Δ
cluster 44.01% <ø> (?)
integrate 44.01% <ø> (+27.92%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/utils/semver.go 7.08% <0.00%> (-79.53%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-77.78%) ⬇️
pkg/repository/progress.go 23.07% <0.00%> (-76.93%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-75.76%) ⬇️
... and 249 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090b201...6b2a804. Read the comment docs.

@nexustar nexustar reopened this Aug 30, 2021
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@nexustar: /merge in this pull request requires 1 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2021
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6b2a804

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2021
@ti-chi-bot ti-chi-bot merged commit 93b0211 into pingcap:master Aug 31, 2021
@nexustar nexustar deleted the fix-dm-test branch September 1, 2021 11:03
@nexustar nexustar added this to the v1.6.0 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants