Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update depends #1544

Merged
merged 3 commits into from
Sep 1, 2021
Merged

*: update depends #1544

merged 3 commits into from
Sep 1, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

  • bump go version to 1.17
  • update dependencies

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Sep 1, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Sep 1, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1544 (ccb2ef6) into master (9fad5c7) will increase coverage by 16.73%.
The diff coverage is n/a.

❗ Current head ccb2ef6 differs from pull request most recent head 732ec28. Consider uploading reports for the commit 732ec28 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1544       +/-   ##
===========================================
+ Coverage   26.32%   43.06%   +16.73%     
===========================================
  Files         267      292       +25     
  Lines       24098    26268     +2170     
===========================================
+ Hits         6345    11312     +4967     
+ Misses      16934    13390     -3544     
- Partials      819     1566      +747     
Flag Coverage Δ
dm 26.24% <ø> (?)
integrate 34.13% <ø> (+17.92%) ⬆️
playground 13.83% <ø> (?)
tiup 16.20% <ø> (ø)
unittest 22.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/logger/audit.go 57.89% <0.00%> (ø)
pkg/cluster/operation/systemd.go 0.00% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 25.86% <0.00%> (ø)
components/playground/instance/tidb.go 84.61% <0.00%> (ø)
pkg/cluster/operation/action.go 56.86% <0.00%> (ø)
components/playground/instance/instance.go 51.72% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash.go 61.98% <0.00%> (ø)
pkg/cluster/operation/destroy.go 34.02% <0.00%> (ø)
components/playground/instance/tikv.go 67.85% <0.00%> (ø)
... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fad5c7...732ec28. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2021
@nexustar nexustar added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@ti-chi-bot ti-chi-bot merged commit 699add6 into pingcap:master Sep 1, 2021
@AstroProfundis AstroProfundis deleted the update-depends branch September 2, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants