Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add --force argument for prune subcommand #1552

Merged
merged 2 commits into from
Sep 6, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1546

What is changed and how it works?

When --force is set, errors are ignored when stopping and deleting the instance.

Check List

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Sep 6, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #1552 (b314668) into master (abd147a) will increase coverage by 10.76%.
The diff coverage is 16.66%.

❗ Current head b314668 differs from pull request most recent head 8a37823. Consider uploading reports for the commit 8a37823 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1552       +/-   ##
===========================================
+ Coverage   26.30%   37.06%   +10.76%     
===========================================
  Files         266      228       -38     
  Lines       24011    21060     -2951     
===========================================
+ Hits         6315     7806     +1491     
+ Misses      16879    12046     -4833     
- Partials      817     1208      +391     
Flag Coverage Δ
cluster 37.06% <16.66%> (?)
integrate 37.06% <16.66%> (+20.95%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/destroy.go 53.09% <0.00%> (ø)
components/cluster/command/prune.go 84.61% <100.00%> (+42.94%) ⬆️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/utils/semver.go 5.51% <0.00%> (-81.11%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-77.78%) ⬇️
... and 232 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd147a...8a37823. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@nexustar
Copy link
Collaborator

nexustar commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fa2e8cc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b718fb0 into pingcap:master Sep 6, 2021
@AstroProfundis AstroProfundis deleted the force-prune branch September 6, 2021 07:28
nexustar pushed a commit to nexustar/tiup that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup deleted the ssh public key before tiup cluster prune task sucess.
4 participants