Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: check tiflash status by requesting it's api #1600

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Close #1591

What is changed and how it works?

Implement a custom Ready() method for TiFlash instances.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has interface methods change

Release notes:

NONE

@AstroProfundis AstroProfundis added the component/cluster Issues about the tiup-cluster component label Oct 26, 2021
@AstroProfundis AstroProfundis added this to the v1.7.0 milestone Oct 26, 2021
@AstroProfundis AstroProfundis self-assigned this Oct 26, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2021
@AstroProfundis AstroProfundis changed the title Tiflash status cluster: check tiflash status by requesting it's api Oct 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1600 (3e2af72) into master (e4b380e) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 3e2af72 differs from pull request most recent head 5761491. Consider uploading reports for the commit 5761491 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   15.74%   15.71%   -0.04%     
==========================================
  Files         149      149              
  Lines       15061    15098      +37     
==========================================
  Hits         2372     2372              
- Misses      12171    12208      +37     
  Partials      518      518              
Flag Coverage Δ
integrate 15.71% <0.00%> (-0.04%) ⬇️
tiup 15.71% <0.00%> (-0.04%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/instance.go 0.00% <0.00%> (ø)
pkg/cluster/spec/tiflash.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b380e...5761491. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5761491

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2021
@ti-chi-bot ti-chi-bot merged commit 956504c into pingcap:master Oct 27, 2021
@AstroProfundis AstroProfundis deleted the tiflash-status branch October 27, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change TiFlash’s upgrade behavior to improve stability
4 participants