-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: update error message of tiflash not ready #1618
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
===========================================
+ Coverage 15.63% 50.75% +35.11%
===========================================
Files 150 291 +141
Lines 15169 26559 +11390
===========================================
+ Hits 2372 13480 +11108
+ Misses 12280 11051 -1229
- Partials 517 2028 +1511
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c9168c1
|
What problem does this PR solve?
The status TiFlash reports could be
Ready
before it becomesRunning
, so the current error message could be confusing.What is changed and how it works?
Adjust the error message.
Check List
Tests
Release notes: