Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: update error message of tiflash not ready #1618

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

The status TiFlash reports could be Ready before it becomes Running, so the current error message could be confusing.
图片
图片

What is changed and how it works?

Adjust the error message.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.7.0 milestone Nov 12, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Nov 12, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #1618 (c9168c1) into master (01843be) will increase coverage by 35.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1618       +/-   ##
===========================================
+ Coverage   15.63%   50.75%   +35.11%     
===========================================
  Files         150      291      +141     
  Lines       15169    26559    +11390     
===========================================
+ Hits         2372    13480    +11108     
+ Misses      12280    11051     -1229     
- Partials      517     2028     +1511     
Flag Coverage Δ
cluster 43.89% <0.00%> (?)
dm 26.24% <0.00%> (?)
integrate 50.75% <0.00%> (+35.11%) ⬆️
playground 13.41% <0.00%> (?)
tiup 15.63% <0.00%> (ø)
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/tiflash.go 51.50% <0.00%> (+51.50%) ⬆️
components/dm/command/upgrade.go 81.81% <0.00%> (ø)
components/cluster/command/scale_in.go 91.66% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
pkg/cluster/ansible/inventory.go 0.00% <0.00%> (ø)
components/dm/spec/bindversion.go 100.00% <0.00%> (ø)
components/playground/main.go 44.96% <0.00%> (ø)
components/playground/monitor.go 85.18% <0.00%> (ø)
components/playground/instance/instance.go 51.72% <0.00%> (ø)
pkg/cluster/task/update_topology.go 70.58% <0.00%> (ø)
... and 235 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01843be...c9168c1. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 12, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c9168c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 12, 2021
@ti-chi-bot ti-chi-bot merged commit d19721b into pingcap:master Nov 12, 2021
@AstroProfundis AstroProfundis deleted the update-errmsg branch November 12, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants