-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: support using provided topo file besides editing it while calling edit-config, add show-config command #1637
cluster: support using provided topo file besides editing it while calling edit-config, add show-config command #1637
Conversation
…of editing it while using edit-config
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
… adding flag --topology-file
Codecov Report
@@ Coverage Diff @@
## master #1637 +/- ##
===========================================
+ Coverage 15.55% 45.71% +30.16%
===========================================
Files 151 294 +143
Lines 15275 26912 +11637
===========================================
+ Hits 2376 12303 +9927
- Misses 12382 12711 +329
- Partials 517 1898 +1381
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 25196cd
|
What problem does this PR solve?
For subcommand
tiup cluster edit-config
, add a flag--topology-file
to allow the user to provide a new topology file to substitute the original one besides editing it.What is changed and how it works?
edit-config
, add a flag--topology-file
to allow the user to provide a new topology file to substitute the original one besides editing it.show-config
commandCheck List
Tests
tiup-cluster
binary and use it as the new component in TiUP central machine.--topology-file
is not specified, it will act like the old flow:--topology-file
and will only 'Check and update Topology.' and 'Save meta file.'../tiup-cluster show-config <cluster-name>
, the cluster's config, which is same as the one shown by opening the topology file to edit while executing./tiup-cluster edit-config <cluster-name>
, will be printed in console.Code changes
Related changes
Release notes: