Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: add support of ng-monitoring #1648

Merged
merged 4 commits into from
Dec 6, 2021

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Dec 2, 2021

What problem does this PR solve?

What is changed and how it works?

  • boot ng-monitoring when boot monitor
  • boot monitor after tidb instance

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@nexustar nexustar removed the request for review from july2993 December 2, 2021 03:44
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #1648 (67518e5) into master (e7f9871) will not change coverage.
The diff coverage is n/a.

❗ Current head 67518e5 differs from pull request most recent head 402a9ae. Consider uploading reports for the commit 402a9ae to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1648   +/-   ##
=======================================
  Coverage   15.57%   15.57%           
=======================================
  Files         151      151           
  Lines       15254    15254           
=======================================
  Hits         2376     2376           
  Misses      12361    12361           
  Partials      517      517           
Flag Coverage Δ
integrate 15.57% <ø> (ø)
tiup 15.57% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f9871...402a9ae. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 6, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 402a9ae

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2021
@ti-chi-bot ti-chi-bot merged commit 592b46c into pingcap:master Dec 6, 2021
@nexustar nexustar added this to the v1.8.0 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support use ng-monitoring in playground
4 participants