-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: skip dir conflict if node marked ignore_exporter #1649
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
===========================================
+ Coverage 15.58% 50.39% +34.81%
===========================================
Files 151 294 +143
Lines 15250 26985 +11735
===========================================
+ Hits 2376 13598 +11222
+ Misses 12357 11316 -1041
- Partials 517 2071 +1554
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1840f0f
|
What problem does this PR solve?
If both clusters have the same monitor deploy dir set in their topology files, scaling out one with
ignore_exporter: true
to a shared host still reporting an directory conflict error.What is changed and how it works?
Ignore dir conflict error if both sides are monitor directories and one of them is marked as
ignore_exporter
.This is a following up of #1492
Check List
Tests
Related changes
Release notes: