Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: ngm server default enabled during deployment #1699

Merged
merged 10 commits into from
Jan 6, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Dec 29, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1699 (5ec3791) into master (99bbe1d) will decrease coverage by 6.58%.
The diff coverage is 27.27%.

❗ Current head 5ec3791 differs from pull request most recent head 9b1282d. Consider uploading reports for the commit 9b1282d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   53.18%   46.60%   -6.58%     
==========================================
  Files         303      303              
  Lines       34199    34207       +8     
==========================================
- Hits        18186    15939    -2247     
- Misses      13872    16342    +2470     
+ Partials     2141     1926     -215     
Flag Coverage Δ
cluster 30.54% <18.18%> (-10.88%) ⬇️
dm 24.77% <9.09%> (+0.04%) ⬆️
playground 12.75% <0.00%> (-<0.01%) ⬇️
tiup 14.63% <0.00%> (+0.02%) ⬆️
unittest 21.34% <18.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/monitoring.go 70.36% <ø> (-2.28%) ⬇️
pkg/cluster/spec/spec.go 77.34% <0.00%> (-6.90%) ⬇️
pkg/cluster/manager/upgrade.go 58.38% <25.00%> (-0.74%) ⬇️
pkg/cluster/spec/validate.go 92.94% <100.00%> (-0.01%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/manager/check.go 0.74% <0.00%> (-68.15%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-57.92%) ⬇️
pkg/cluster/template/config/alertmanager.go 0.00% <0.00%> (-55.00%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99bbe1d...9b1282d. Read the comment docs.

@nexustar nexustar requested review from AstroProfundis and removed request for lucklove and birdstorm December 30, 2021 05:34
@nexustar nexustar changed the title [Draft] cluster: ngm server default enabled during deployment cluster: ngm server default enabled during deployment Jan 4, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c0b9e1b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2022
@ti-chi-bot ti-chi-bot merged commit e97056e into pingcap:master Jan 6, 2022
@nexustar nexustar added this to the v1.9.0 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster :ngm server default enabled during deployment
4 participants