Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: use initial_commit_ts in drainer config file instead of start script #1706

Merged
merged 6 commits into from
Jan 6, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Jan 4, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1706 (c45e6b8) into master (e97056e) will increase coverage by 28.72%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1706       +/-   ##
===========================================
+ Coverage   24.47%   53.18%   +28.72%     
===========================================
  Files         277      303       +26     
  Lines       31412    34245     +2833     
===========================================
+ Hits         7686    18213    +10527     
+ Misses      22875    13886     -8989     
- Partials      851     2146     +1295     
Flag Coverage Δ
cluster 41.41% <50.00%> (?)
dm 24.73% <0.00%> (?)
playground 12.73% <0.00%> (?)
tiup 14.60% <0.00%> (+0.02%) ⬆️
unittest 21.36% <28.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/ansible/service.go 4.60% <0.00%> (-0.02%) ⬇️
pkg/cluster/spec/drainer.go 60.71% <ø> (+57.19%) ⬆️
pkg/cluster/template/scripts/drainer.go 70.73% <ø> (+70.73%) ⬆️
pkg/cluster/spec/spec.go 82.83% <58.33%> (+30.65%) ⬆️
pkg/cluster/operation/destroy.go 59.40% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 55.13% <0.00%> (ø)
pkg/logger/audit.go 52.17% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/playground/instance/process.go 81.97% <0.00%> (ø)
components/playground/instance/tiflash_config.go 70.59% <0.00%> (ø)
... and 220 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97056e...c45e6b8. Read the comment docs.

@AstroProfundis AstroProfundis modified the milestones: v1.8.2, v1.9.0 Jan 5, 2022
pkg/cluster/spec/drainer.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c580f10

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2022
@ti-chi-bot ti-chi-bot merged commit e7e5689 into pingcap:master Jan 6, 2022
@nexustar nexustar self-assigned this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--initial-commit-ts should not be recorded at run_drainer.sh
5 participants