-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: fix cannot find nightly version #1715
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
- Coverage 53.29% 53.19% -0.10%
==========================================
Files 303 303
Lines 34261 34267 +6
==========================================
- Hits 18256 18226 -30
- Misses 13864 13897 +33
- Partials 2141 2144 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
We should also add a note on the "starting component" outputs to let users know which version of the component is actually running (as they may not with strictly the same version anymore) |
this fix is for v1.8.x, I will prepare another PR for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3bc7008
|
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: