Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: add TLS support #1745

Merged
merged 8 commits into from
Feb 9, 2022
Merged

dm: add TLS support #1745

merged 8 commits into from
Feb 9, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Jan 28, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • deploy display scale-in scale-out works

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022

Codecov Report

Merging #1745 (84ce79d) into master (15cd08a) will increase coverage by 28.63%.
The diff coverage is 47.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1745       +/-   ##
===========================================
+ Coverage   24.44%   53.06%   +28.63%     
===========================================
  Files         277      303       +26     
  Lines       31489    34396     +2907     
===========================================
+ Hits         7695    18252    +10557     
+ Misses      22939    13992     -8947     
- Partials      855     2152     +1297     
Flag Coverage Δ
cluster 41.29% <0.00%> (?)
dm 24.74% <47.25%> (?)
playground 12.62% <0.00%> (?)
tiup 14.40% <0.00%> (-<0.01%) ⬇️
unittest 21.34% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/command/prune.go 54.17% <40.00%> (+46.81%) ⬆️
pkg/utils/utils.go 69.70% <40.00%> (+19.70%) ⬆️
components/dm/spec/logic.go 66.21% <44.00%> (+65.32%) ⬆️
components/dm/command/scale_in.go 59.41% <100.00%> (+49.50%) ⬆️
pkg/cluster/template/scripts/dm_master.go 66.29% <100.00%> (+66.29%) ⬆️
components/playground/instance/tiflash.go 59.12% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/operation.go 80.65% <0.00%> (ø)
pkg/cluster/operation/download.go 33.33% <0.00%> (ø)
pkg/cluster/operation/systemd.go 75.00% <0.00%> (ø)
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cd08a...84ce79d. Read the comment docs.

@nexustar
Copy link
Collaborator Author

nexustar commented Feb 7, 2022

master-addr and worker-addr cannot be 0.0.0.0 due to bug of DM pingcap/tiflow#4511

@nexustar nexustar modified the milestones: v1.10.0, v1.9.0 Feb 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2022
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dm prune command also needs tlsConflig.
Rest LGTM

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@lichunzhu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nexustar nexustar changed the title [Draft] dm: add TLS support dm: add TLS support Feb 8, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 84ce79d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@ti-chi-bot ti-chi-bot merged commit 111f294 into pingcap:master Feb 9, 2022
@nexustar nexustar mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tls for tiup-dm
6 participants