Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --ignore-config-check not working for deploy #1774

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

fix #1773

What is changed and how it works?

There were two IgnoreConfigCheck fields, and the one in DeployOptions was never used (it was moved to operator.Options about a year ago)

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported variable/fields change

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.9.2 milestone Mar 1, 2022
@AstroProfundis AstroProfundis requested a review from srstack March 1, 2022 08:51
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Mar 1, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #1774 (bb37c16) into master (9d3f141) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
- Coverage   53.21%   53.14%   -0.08%     
==========================================
  Files         303      303              
  Lines       34436    34436              
==========================================
- Hits        18325    18299      -26     
- Misses      13967    13985      +18     
- Partials     2144     2152       +8     
Flag Coverage Δ
cluster 41.38% <100.00%> (-0.03%) ⬇️
dm 24.81% <ø> (-0.09%) ⬇️
playground 12.61% <ø> (ø)
tiup 14.40% <ø> (-0.02%) ⬇️
unittest 21.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/deploy.go 68.60% <ø> (ø)
components/cluster/command/deploy.go 64.81% <100.00%> (ø)
pkg/cluster/api/dmapi.go 59.88% <0.00%> (-5.81%) ⬇️
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/cluster/api/pdapi.go 59.47% <0.00%> (-1.59%) ⬇️
components/dm/spec/topology_dm.go 84.31% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3f141...bb37c16. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2022
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb37c16

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@ti-chi-bot ti-chi-bot merged commit f0b24cf into pingcap:master Mar 2, 2022
@AstroProfundis AstroProfundis deleted the fix-skip-confchk branch March 10, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore-config-check not working
4 participants