Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: check active before reload promtheus when scale-in/scale-out #1775

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Mar 2, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #1775 (75644e6) into master (82c3791) will decrease coverage by 12.43%.
The diff coverage is 93.75%.

❗ Current head 75644e6 differs from pull request most recent head 403995c. Consider uploading reports for the commit 403995c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1775       +/-   ##
===========================================
- Coverage   53.14%   40.70%   -12.43%     
===========================================
  Files         303      302        -1     
  Lines       34436    34431        -5     
===========================================
- Hits        18298    14014     -4284     
- Misses      13986    18527     +4541     
+ Partials     2152     1890      -262     
Flag Coverage Δ
cluster 32.04% <93.75%> (-9.30%) ⬇️
dm 23.39% <93.75%> (-1.49%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/check.go 0.68% <0.00%> (-67.63%) ⬇️
pkg/cluster/manager/destroy.go 49.14% <ø> (-3.45%) ⬇️
pkg/cluster/manager/builder.go 70.65% <100.00%> (-2.10%) ⬇️
pkg/cluster/manager/scale_in.go 48.81% <100.00%> (ø)
pkg/cluster/module/systemd.go 73.17% <100.00%> (+2.90%) ⬆️
pkg/cluster/task/builder.go 75.77% <100.00%> (-24.23%) ⬇️
pkg/cluster/task/systemd.go 63.64% <100.00%> (+1.73%) ⬆️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c3791...403995c. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2022
@srstack
Copy link
Collaborator

srstack commented Mar 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b559b46

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@ti-chi-bot ti-chi-bot merged commit caab563 into pingcap:master Mar 7, 2022
@nexustar nexustar added this to the v1.9.2 milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster: scale-in stopped prometheus failed
4 participants