Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Oracle Linux 2 as supported OS #1786

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Mar 9, 2022

What problem does this PR solve?

Add Oracle Linux 2 as supported OS

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@srstack srstack self-assigned this Mar 9, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #1786 (30fc81a) into master (b2ed8aa) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

❗ Current head 30fc81a differs from pull request most recent head f68f2d4. Consider uploading reports for the commit f68f2d4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1786      +/-   ##
==========================================
- Coverage   53.08%   52.86%   -0.22%     
==========================================
  Files         303      303              
  Lines       34624    34587      -37     
==========================================
- Hits        18379    18282      -97     
- Misses      14084    14150      +66     
+ Partials     2161     2155       -6     
Flag Coverage Δ
cluster 41.07% <0.00%> (-0.30%) ⬇️
dm 24.82% <0.00%> (-0.06%) ⬇️
tiup 14.40% <ø> (ø)
unittest 21.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/check.go 48.44% <0.00%> (ø)
pkg/cluster/template/config/alertmanager.go 0.00% <0.00%> (-55.00%) ⬇️
pkg/utils/retry.go 46.43% <0.00%> (-16.07%) ⬇️
pkg/cluster/spec/tikv.go 55.74% <0.00%> (-6.89%) ⬇️
pkg/cluster/audit/audit.go 38.84% <0.00%> (-4.74%) ⬇️
pkg/utils/ioutil.go 60.09% <0.00%> (-4.60%) ⬇️
pkg/cluster/spec/alertmanager.go 65.22% <0.00%> (-2.17%) ⬇️
pkg/cluster/api/pdapi.go 57.35% <0.00%> (-2.12%) ⬇️
pkg/cluster/spec/server_config.go 70.72% <0.00%> (-0.90%) ⬇️
components/dm/command/audit.go 59.38% <0.00%> (+1.80%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fdb133...f68f2d4. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2022
@srstack
Copy link
Collaborator Author

srstack commented Mar 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f68f2d4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2022
@ti-chi-bot ti-chi-bot merged commit 28f9267 into pingcap:master Mar 9, 2022
@AstroProfundis AstroProfundis added this to the v1.9.2 milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants