Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: fix print duplicated component path #1832

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Apr 2, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@nexustar nexustar added this to the v1.9.4 milestone Apr 2, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from lucklove and srstack April 2, 2022 07:08
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #1832 (dfddd9e) into master (9060112) will decrease coverage by 0.60%.
The diff coverage is 100.00%.

❗ Current head dfddd9e differs from pull request most recent head b757b39. Consider uploading reports for the commit b757b39 to get more accurate results

@@            Coverage Diff             @@
##           master    #1832      +/-   ##
==========================================
- Coverage   53.00%   52.40%   -0.60%     
==========================================
  Files         303      303              
  Lines       34678    34678              
==========================================
- Hits        18381    18173     -208     
- Misses      14147    14360     +213     
+ Partials     2150     2145       -5     
Flag Coverage Δ
cluster 40.46% <ø> (-0.80%) ⬇️
dm 24.72% <ø> (-0.04%) ⬇️
playground 12.64% <0.00%> (ø)
tiup 14.42% <100.00%> (ø)
unittest 21.31% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/exec/run.go 54.76% <100.00%> (ø)
pkg/cluster/template/config/alertmanager.go 0.00% <0.00%> (-55.00%) ⬇️
pkg/utils/retry.go 46.43% <0.00%> (-16.07%) ⬇️
pkg/cluster/api/pdapi.go 46.05% <0.00%> (-13.01%) ⬇️
pkg/cluster/task/task.go 64.81% <0.00%> (-8.33%) ⬇️
pkg/tui/cliutil.go 69.77% <0.00%> (-6.98%) ⬇️
pkg/cluster/spec/tikv.go 55.74% <0.00%> (-6.89%) ⬇️
pkg/cluster/operation/scale_in.go 50.00% <0.00%> (-5.13%) ⬇️
pkg/cluster/task/step.go 64.94% <0.00%> (-3.90%) ⬇️
pkg/cluster/manager/destroy.go 51.64% <0.00%> (-3.28%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9060112...b757b39. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2022
@nexustar
Copy link
Collaborator Author

nexustar commented Apr 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b757b39

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2022
@nexustar nexustar closed this Apr 8, 2022
@nexustar nexustar reopened this Apr 8, 2022
@ti-chi-bot ti-chi-bot merged commit 542d9f2 into pingcap:master Apr 8, 2022
@AstroProfundis AstroProfundis modified the milestones: v1.9.4, v1.10.0 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicated info printed when running command
5 participants