Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: enable data-dir for versions above v5.0.3 #1838

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented Apr 11, 2022

What problem does this PR solve?

Fix cdc data-dir is not enable properly for v6.0.0

Cc pingcap/tiflow#5142

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release notes:

Fix cdc data-dir is not enable properly for v6.0.0

Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2022
@srstack srstack added this to the v1.10.0 milestone Apr 12, 2022
@ti-chi-bot
Copy link
Member

@3AceShowHand: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 050ef93

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1838 (050ef93) into master (542d9f2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1838      +/-   ##
==========================================
- Coverage   53.03%   53.00%   -0.03%     
==========================================
  Files         303      303              
  Lines       34678    34675       -3     
==========================================
- Hits        18389    18377      -12     
- Misses      14141    14147       +6     
- Partials     2148     2151       +3     
Flag Coverage Δ
cluster 41.26% <100.00%> (+0.01%) ⬆️
dm 24.73% <0.00%> (-0.06%) ⬇️
playground 12.64% <0.00%> (+<0.01%) ⬆️
tiup 14.39% <0.00%> (-0.02%) ⬇️
unittest 21.31% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/template/scripts/cdc.go 78.26% <100.00%> (-0.91%) ⬇️
pkg/cluster/api/dmapi.go 59.88% <0.00%> (-4.07%) ⬇️
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/cluster/spec/tiflash.go 68.51% <0.00%> (-0.67%) ⬇️
components/dm/spec/topology_dm.go 84.31% <0.00%> (-0.57%) ⬇️
pkg/cluster/api/pdapi.go 60.63% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542d9f2...050ef93. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit bdc10b9 into pingcap:master Apr 12, 2022
@AstroProfundis AstroProfundis modified the milestones: v1.10.0, v1.9.4 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants