-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: enable data-dir for versions above v5.0.3 #1838
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@3AceShowHand: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
LGTM |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 050ef93
|
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
==========================================
- Coverage 53.03% 53.00% -0.03%
==========================================
Files 303 303
Lines 34678 34675 -3
==========================================
- Hits 18389 18377 -12
- Misses 14141 14147 +6
- Partials 2148 2151 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
Fix cdc data-dir is not enable properly for v6.0.0
Cc pingcap/tiflow#5142
Check List
Tests
Related changes
Release notes: