Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror: support custom key-dir when rotate root.json #1848

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Add --key-dir argument to mirror rotate subcommand

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

@AstroProfundis AstroProfundis added the component/tiup Issues about the TiUP package management component itself label Apr 18, 2022
@AstroProfundis AstroProfundis requested a review from lucklove April 18, 2022 09:11
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Apr 18, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #1848 (51ddaae) into master (a1f44d7) will decrease coverage by 5.59%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
- Coverage   52.59%   47.01%   -5.59%     
==========================================
  Files         306      306              
  Lines       34975    35062      +87     
==========================================
- Hits        18395    16481    -1914     
- Misses      14418    16626    +2208     
+ Partials     2162     1955     -207     
Flag Coverage Δ
cluster 32.08% <100.00%> (-9.01%) ⬇️
playground 12.79% <100.00%> (+0.18%) ⬆️
tiup 14.44% <35.71%> (+<0.01%) ⬆️
unittest 21.26% <13.33%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/model/model.go 36.95% <0.00%> (-6.65%) ⬇️
cmd/mirror.go 44.56% <18.18%> (-0.38%) ⬇️
cmd/root.go 56.36% <100.00%> (ø)
components/cluster/command/root.go 46.02% <100.00%> (ø)
components/dm/command/root.go 56.50% <100.00%> (ø)
components/playground/main.go 45.06% <100.00%> (ø)
pkg/environment/env.go 59.28% <100.00%> (-1.80%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-63.64%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f44d7...51ddaae. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2022
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 51ddaae

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@ti-chi-bot ti-chi-bot merged commit 0567f77 into pingcap:master Apr 18, 2022
@AstroProfundis AstroProfundis deleted the fix-rotate branch September 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tiup Issues about the TiUP package management component itself size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants