Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster prune will destroy pump/drainer directly after scale-in #1851

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Apr 20, 2022

What problem does this PR solve?

close #1850

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack self-assigned this Apr 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #1851 (aa88c70) into master (e5b8861) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
+ Coverage   52.52%   52.53%   +0.01%     
==========================================
  Files         306      306              
  Lines       34986    34986              
==========================================
+ Hits        18374    18379       +5     
+ Misses      14449    14439      -10     
- Partials     2163     2168       +5     
Flag Coverage Δ
cluster 40.84% <50.00%> (+0.02%) ⬆️
dm 24.55% <0.00%> (ø)
playground 12.79% <ø> (ø)
tiup 14.44% <ø> (ø)
unittest 21.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/destroy.go 60.08% <50.00%> (ø)
pkg/cluster/task/update_meta.go 84.95% <0.00%> (-2.15%) ⬇️
pkg/cluster/api/pdapi.go 57.47% <0.00%> (-1.05%) ⬇️
pkg/cluster/spec/tikv.go 62.62% <0.00%> (+1.31%) ⬆️
pkg/utils/retry.go 62.50% <0.00%> (+16.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b8861...aa88c70. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.10.0 milestone Apr 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aa88c70

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2022
@ti-chi-bot ti-chi-bot merged commit 762dd94 into pingcap:master Apr 20, 2022
@AstroProfundis AstroProfundis modified the milestones: v1.10.0, 1.9.5 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster: prune will destroy pump/drainer directly after scale-in.
4 participants