Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exporter and grafana are abnormal in prometheus #1853

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Apr 20, 2022

What problem does this PR solve?

close #1852

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack self-assigned this Apr 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #1853 (0945772) into master (762dd94) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
- Coverage   52.62%   52.53%   -0.08%     
==========================================
  Files         306      306              
  Lines       34986    34986              
==========================================
- Hits        18408    18379      -29     
- Misses      14418    14439      +21     
- Partials     2160     2168       +8     
Flag Coverage Δ
cluster 40.84% <ø> (-0.08%) ⬇️
dm 24.55% <ø> (-0.04%) ⬇️
playground 12.79% <ø> (ø)
tiup 14.44% <ø> (-0.02%) ⬇️
unittest 21.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/api/pdapi.go 57.47% <0.00%> (-3.16%) ⬇️
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/cluster/api/dmapi.go 59.88% <0.00%> (-1.74%) ⬇️
pkg/cluster/spec/tiflash.go 68.51% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762dd94...0945772. Read the comment docs.

@srstack srstack added this to the v1.10.0 milestone Apr 21, 2022
Copy link
Collaborator

@nexustar nexustar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of use tcp on all port probe, I think we had better use another job

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2022
@srstack
Copy link
Collaborator Author

srstack commented Apr 21, 2022

instead of use tcp on all port probe, I think we had better use another job

cc

@srstack srstack requested a review from nexustar April 22, 2022 06:47
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0945772

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@ti-chi-bot ti-chi-bot merged commit 8a84f00 into pingcap:master Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster: enable tls, exporter and grafana are abnormal in prometheus
4 participants