Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: return error when found multiple nodes with the same ip:port #1856

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Apr 23, 2022

What problem does this PR solve?

close #1854

I think that when there are multiple nodes with the same ip:port, an error should be returned and the client should check.

image

image

Release notes:

NONE

@srstack srstack self-assigned this Apr 23, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #1856 (6421cd7) into master (ebde574) will increase coverage by 0.60%.
The diff coverage is 41.51%.

@@            Coverage Diff             @@
##           master    #1856      +/-   ##
==========================================
+ Coverage   51.93%   52.53%   +0.60%     
==========================================
  Files         306      306              
  Lines       35109    35133      +24     
==========================================
+ Hits        18233    18457     +224     
+ Misses      14693    14490     -203     
- Partials     2183     2186       +3     
Flag Coverage Δ
cluster 40.88% <41.51%> (+0.93%) ⬆️
dm 24.53% <0.00%> (-0.02%) ⬇️
playground 12.74% <0.00%> (-0.02%) ⬇️
tiup 14.36% <0.00%> (-0.07%) ⬇️
unittest 21.20% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/api/binlog.go 38.74% <41.51%> (+2.82%) ⬆️
pkg/utils/http_client.go 46.56% <0.00%> (-2.29%) ⬇️
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/cluster/manager/scale_out.go 41.33% <0.00%> (+0.51%) ⬆️
pkg/cluster/manager/builder.go 73.09% <0.00%> (+0.64%) ⬆️
pkg/cluster/manager/display.go 49.47% <0.00%> (+0.89%) ⬆️
pkg/cluster/operation/action.go 62.53% <0.00%> (+0.92%) ⬆️
pkg/cluster/executor/ssh.go 64.10% <0.00%> (+1.10%) ⬆️
pkg/cluster/spec/monitoring.go 67.80% <0.00%> (+1.55%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebde574...6421cd7. Read the comment docs.

@srstack srstack added this to the v1.11.0 milestone Apr 23, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2022
@srstack srstack modified the milestones: v1.11.0, v1.10.0 Apr 27, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6421cd7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2022
@AstroProfundis AstroProfundis modified the milestones: v1.10.0, 1.9.5 May 10, 2022
@ti-chi-bot ti-chi-bot merged commit 9cb504f into pingcap:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster: get the status of online pump nodeid.
4 participants