-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: return error when found multiple nodes with the same ip:port #1856
cluster: return error when found multiple nodes with the same ip:port #1856
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 51.93% 52.53% +0.60%
==========================================
Files 306 306
Lines 35109 35133 +24
==========================================
+ Hits 18233 18457 +224
+ Misses 14693 14490 -203
- Partials 2183 2186 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…--get-the-status-of-online-pump-nodeid
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6421cd7
|
What problem does this PR solve?
close #1854
I think that when there are multiple nodes with the same ip:port, an error should be returned and the client should check.
Release notes: