Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctl: add tidb-lightning #1863

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Apr 26, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from july2993 and lucklove April 26, 2022 11:20
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #1863 (40abe53) into master (12b9e99) will decrease coverage by 9.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1863      +/-   ##
==========================================
- Coverage   24.18%   14.38%   -9.80%     
==========================================
  Files         280      156     -124     
  Lines       32218    19465   -12753     
==========================================
- Hits         7791     2800    -4991     
+ Misses      23557    16128    -7429     
+ Partials      870      537     -333     
Flag Coverage Δ
tiup 14.38% <ø> (-0.02%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
embed/embed.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/spec/validate.go 0.00% <0.00%> (-90.92%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/utils/semver.go 3.59% <0.00%> (-80.84%) ⬇️
pkg/cluster/spec/parse_topology.go 0.00% <0.00%> (-79.41%) ⬇️
pkg/cluster/executor/checkpoint.go 0.00% <0.00%> (-77.36%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b9e99...40abe53. Read the comment docs.

@nexustar nexustar added this to the 1.9.5 milestone May 6, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 40abe53

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2022
@ti-chi-bot ti-chi-bot merged commit 9e7e043 into pingcap:master May 9, 2022
AstroProfundis pushed a commit that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup-ctl support lightning
4 participants