Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies #1868

Merged
merged 5 commits into from
May 27, 2022
Merged

bump dependencies #1868

merged 5 commits into from
May 27, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented May 5, 2022

What problem does this PR solve?

close #1609

What is changed and how it works?

  • update dependencies

Check List

Tests

  • Manual test (add detailed scripts or steps below)

new version of golang.org/x/crypto make it is possible to use tiup-cluster when target machine has openssh higher than 8.8p1
tested on Debian sid cloud image with OpenSSH_9.0p1 and CentOS Stream 9 with OpenSSH 8.7p1

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 5, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #1868 (190505e) into master (bda2367) will decrease coverage by 5.31%.
The diff coverage is n/a.

❗ Current head 190505e differs from pull request most recent head b927974. Consider uploading reports for the commit b927974 to get more accurate results

@@            Coverage Diff             @@
##           master    #1868      +/-   ##
==========================================
- Coverage   47.46%   42.15%   -5.31%     
==========================================
  Files         307      306       -1     
  Lines       35454    35443      -11     
==========================================
- Hits        16825    14938    -1887     
- Misses      16643    18523    +1880     
+ Partials     1986     1982       -4     
Flag Coverage Δ
tiup 14.45% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-70.73%) ⬇️
pkg/utils/error.go 0.00% <0.00%> (-64.29%) ⬇️
components/dm/ansible/import.go 0.00% <0.00%> (-61.63%) ⬇️
pkg/telemetry/scrub.go 12.31% <0.00%> (-60.00%) ⬇️
pkg/cluster/executor/local.go 0.00% <0.00%> (-59.38%) ⬇️
pkg/cluster/ansible/inventory.go 0.00% <0.00%> (-57.78%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda2367...b927974. Read the comment docs.

@nexustar nexustar added this to the v1.10.0 milestone May 6, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b927974

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot merged commit 5a9c0b3 into pingcap:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP cluster does not work with builtin ssh executor
4 participants