-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: exit faster #1893
playground: exit faster #1893
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1893 +/- ##
===========================================
- Coverage 52.13% 41.78% -10.36%
===========================================
Files 307 306 -1
Lines 35387 35376 -11
===========================================
- Hits 18448 14779 -3669
- Misses 14751 18611 +3860
+ Partials 2188 1986 -202
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
if p.monitor != nil { | ||
kill(p.monitor.cmd.Process.Pid, p.monitor.wait) | ||
go kill("prometheus", p.monitor.cmd.Process.Pid, p.monitor.wait) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it be possible to remain as zombie process if it hangs on kill?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entire terminate function are in a goroutine and there are another wait goroutine.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 449ec51
|
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: