Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix ineffectiveness of ticdc.config #1978

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Jul 9, 2022

Issue Number: #1977

Signed-off-by: pingyu yuping@pingcap.com

What problem does this PR solve?

#1977

What is changed and how it works?

Add "--config=" to arguments of TiCDC.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. Prepare cdc.toml:
log-level = "debug"
  1. Start playground
tiup-playground nightly --db 1 --tiflash 0 --kv 1 --kv.config etc/tikv-v2.toml --pd 1 --pd.config etc/pd.toml --ticdc 1 --ticdc.config etc/cdc.toml
  1. Check log level of "cdc.log"
> cat cdc-0/ticdc.log
...
[2022/07/09 17:32:48.124 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:48.124 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:48.124 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:48.124 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:49.125 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:49.125 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:49.125 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:49.125 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:50.126 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:50.126 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
[2022/07/09 17:32:50.126 +08:00] [DEBUG] [etcd_worker.go:178] ["Etcd progress notification"] [revision=1284165]
...

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
    TBD

Release notes:

fix ineffectiveness of "ticdc.config" of playground

Issue Number: pingcap#1977

Signed-off-by: pingyu <yuping@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from birdstorm and lonng July 9, 2022 09:37
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #1978 (6500dae) into master (8117e9a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 6500dae differs from pull request most recent head 39157d1. Consider uploading reports for the commit 39157d1 to get more accurate results

@@            Coverage Diff             @@
##           master    #1978      +/-   ##
==========================================
- Coverage   52.56%   52.55%   -0.00%     
==========================================
  Files         307      307              
  Lines       35482    35485       +3     
==========================================
  Hits        18648    18648              
- Misses      14641    14644       +3     
  Partials     2193     2193              
Flag Coverage Δ
playground 12.97% <0.00%> (-<0.01%) ⬇️
tiup 14.45% <ø> (ø)
unittest 21.02% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c492ceb...39157d1. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6500dae

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022
@ti-chi-bot
Copy link
Member

@pingyu: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit de5991d into pingcap:master Jul 14, 2022
@nexustar nexustar added this to the v1.11.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants