-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: fix ineffectiveness of ticdc.config #1978
Conversation
Issue Number: pingcap#1977 Signed-off-by: pingyu <yuping@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1978 +/- ##
==========================================
- Coverage 52.56% 52.55% -0.00%
==========================================
Files 307 307
Lines 35482 35485 +3
==========================================
Hits 18648 18648
- Misses 14641 14644 +3
Partials 2193 2193
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6500dae
|
@pingyu: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Issue Number: #1977
Signed-off-by: pingyu yuping@pingcap.com
What problem does this PR solve?
#1977
What is changed and how it works?
Add "--config=" to arguments of TiCDC.
Check List
Tests
cdc.toml
:Code changes
Side effects
Related changes
TBD
Release notes: