cluster: unable to configure tiflash LearnerConfig

[srstack]

What problem does this PR solve?

close #1975

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has exported function/method change
• Has exported variable/fields change
• Has interface methods change
• Has persistent data change

Side effects

• Possible performance regression
• Increased code complexity
• Breaking backward compatibility

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Release notes:

NONE

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov-commenter]

Codecov Report

Merging #1991 (6fb2ef2) into master (de5991d) will decrease coverage by 28.60%.
The diff coverage is 0.00%.

❗ Current head 6fb2ef2 differs from pull request most recent head 25ed1cb. Consider uploading reports for the commit 25ed1cb to get more accurate results

@@             Coverage Diff             @@
##           master    #1991       +/-   ##
===========================================
- Coverage   52.54%   23.94%   -28.60%     
===========================================
  Files         307      281       -26     
  Lines       35485    32539     -2946     
===========================================
- Hits        18645     7791    -10854     
- Misses      14646    23879     +9233     
+ Partials     2194      869     -1325     

Flag	Coverage Δ
cluster	?
dm	?
playground	?
tiup	14.48% <0.00%> (+0.03%)	⬆️
unittest	21.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cluster/spec/tiflash.go	44.22% <0.00%> (-24.96%)	⬇️
pkg/meta/paths.go	0.00% <0.00%> (-100.00%)	⬇️
components/dm/main.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/tidbver/tidbver.go	0.00% <0.00%> (-100.00%)	⬇️
components/cluster/main.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/cluster/task/builder.go	0.00% <0.00%> (-100.00%)	⬇️
components/dm/spec/bindversion.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/cluster/template/config/config.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/cluster/template/scripts/scripts.go	0.00% <0.00%> (-100.00%)	⬇️
components/dm/spec/cluster.go	0.00% <0.00%> (-91.67%)	⬇️
... and 216 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5991d...25ed1cb. Read the comment docs.

[Lloyd-Pottiger]

lgtm

[ti-chi-bot]

@Lloyd-Pottiger: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[srstack]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 25ed1cb