Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: retry on resign the owner, if old owner in power again. #2036

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

retry on owner resign, to make it more robust.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Base: 44.99% // Head: 48.36% // Increases project coverage by +3.37% 🎉

Coverage data is based on head (204dee6) compared to base (3671d82).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 204dee6 differs from pull request most recent head 37f7736. Consider uploading reports for the commit 37f7736 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2036      +/-   ##
==========================================
+ Coverage   44.99%   48.36%   +3.37%     
==========================================
  Files         309      309              
  Lines       36034    36042       +8     
==========================================
+ Hits        16212    17431    +1219     
+ Misses      17871    16549    -1322     
- Partials     1951     2062     +111     
Flag Coverage Δ
cluster 34.98% <0.00%> (+6.12%) ⬆️
dm 24.05% <0.00%> (-0.05%) ⬇️
playground 13.29% <0.00%> (+0.07%) ⬆️
tiup 14.24% <0.00%> (-0.01%) ⬇️
unittest 20.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/api/cdcapi.go 42.86% <0.00%> (+42.86%) ⬆️
pkg/cluster/spec/cdc.go 55.88% <0.00%> (+19.41%) ⬆️
pkg/cluster/api/dmapi.go 59.88% <0.00%> (-1.74%) ⬇️
components/playground/main.go 49.31% <0.00%> (+0.20%) ⬆️
pkg/cluster/spec/grafana.go 64.76% <0.00%> (+0.95%) ⬆️
components/playground/playground.go 51.65% <0.00%> (+0.99%) ⬆️
pkg/cluster/executor/ssh.go 62.27% <0.00%> (+1.10%) ⬆️
pkg/utils/ioutil.go 49.81% <0.00%> (+1.17%) ⬆️
pkg/cluster/manager/display.go 45.63% <0.00%> (+1.22%) ⬆️
pkg/cluster/manager/upgrade.go 60.00% <0.00%> (+1.62%) ⬆️
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 37f7736

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2022
@ti-chi-bot ti-chi-bot merged commit fb81eac into pingcap:master Sep 13, 2022
@nexustar nexustar added this to the v1.11.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants