Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix timezone check and remove duplicate cleanTasks #2045

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@nexustar nexustar added this to the v1.11.0 milestone Sep 22, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Base: 43.08% // Head: 51.59% // Increases project coverage by +8.51% 🎉

Coverage data is based on head (4737f5d) compared to base (4397175).
Patch coverage: 92.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
+ Coverage   43.08%   51.59%   +8.51%     
==========================================
  Files         314      314              
  Lines       36491    36510      +19     
==========================================
+ Hits        15722    18837    +3115     
+ Misses      18890    15456    -3434     
- Partials     1879     2217     +338     
Flag Coverage Δ
cluster 40.19% <92.78%> (+11.59%) ⬆️
dm 23.72% <0.00%> (+5.66%) ⬆️
playground 12.94% <ø> (+0.01%) ⬆️
tiup 13.93% <ø> (ø)
unittest 20.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/check.go 69.41% <92.78%> (+64.35%) ⬆️
pkg/cluster/api/cdcapi.go 18.37% <0.00%> (-20.41%) ⬇️
pkg/cluster/spec/cdc.go 43.35% <0.00%> (-10.98%) ⬇️
pkg/utils/http_client.go 41.72% <0.00%> (-3.07%) ⬇️
pkg/cluster/api/binlog.go 36.65% <0.00%> (-1.57%) ⬇️
components/playground/playground.go 50.99% <0.00%> (+0.33%) ⬆️
pkg/repository/v1_repository.go 62.82% <0.00%> (+0.47%) ⬆️
pkg/cluster/manager/scale_out.go 41.33% <0.00%> (+0.51%) ⬆️
pkg/cluster/spec/server_config.go 71.62% <0.00%> (+0.90%) ⬆️
pkg/cluster/spec/grafana.go 64.76% <0.00%> (+1.43%) ⬆️
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2022
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4737f5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 23, 2022
@ti-chi-bot ti-chi-bot merged commit 9c3b4c2 into pingcap:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants