Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: avoid redirect when grafana set root_url #2082

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@nexustar nexustar added this to the 1.11.1 milestone Nov 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Base: 55.19% // Head: 54.53% // Decreases project coverage by -0.66% ⚠️

Coverage data is based on head (fc858ff) compared to base (5c4bd1f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
- Coverage   55.19%   54.53%   -0.66%     
==========================================
  Files         313      313              
  Lines       33173    33173              
==========================================
- Hits        18308    18089     -219     
- Misses      12672    12903     +231     
+ Partials     2193     2181      -12     
Flag Coverage Δ
cluster 42.32% <100.00%> (-2.39%) ⬇️
dm 26.30% <100.00%> (+6.41%) ⬆️
playground 15.23% <0.00%> (ø)
tiup 16.47% <0.00%> (ø)
unittest 22.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/grafana.go 63.98% <100.00%> (-0.95%) ⬇️
pkg/cluster/api/cdcapi.go 0.00% <0.00%> (-53.49%) ⬇️
pkg/cluster/api/binlog.go 5.76% <0.00%> (-32.46%) ⬇️
pkg/cluster/operation/scale_in.go 23.51% <0.00%> (-25.39%) ⬇️
pkg/cluster/template/scripts/pd.go 15.79% <0.00%> (-21.05%) ⬇️
pkg/cluster/task/update_meta.go 63.48% <0.00%> (-19.13%) ⬇️
pkg/cluster/spec/cdc.go 40.22% <0.00%> (-19.02%) ⬇️
pkg/utils/retry.go 46.43% <0.00%> (-16.07%) ⬇️
pkg/cluster/manager/destroy.go 35.77% <0.00%> (-15.45%) ⬇️
pkg/cluster/spec/pd.go 54.68% <0.00%> (-13.11%) ⬇️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@nexustar: /merge in this pull request requires 1 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2022
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fc858ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@ti-chi-bot ti-chi-bot merged commit 7bf28c9 into pingcap:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup display show grafana is down when config root_url for grafana
4 participants