Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mark_cache_size default value of tiflash.toml after v5.4.0 #2138

Merged

Conversation

hongyunyan
Copy link
Contributor

What problem does this PR solve?

ref pingcap/tiflash#6861

What is changed and how it works?

Remove mark_cache_size default value of tiflash.toml after v5.4.0
Because tiflash add default_mark_cache_size = 5G in code from v5.4.0, so for the version after v5.4.0, we can directly remove this item in config.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    use tiup-playground and tiup-cluster to start cluster in nightly and v5.3.0 to check the tiflash.toml
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kaaaaaaang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2023
@hongyunyan
Copy link
Contributor Author

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
pkg/cluster/spec/tiflash.go Outdated Show resolved Hide resolved
@hongyunyan hongyunyan force-pushed the hongyunyan_change_mark_cache_size branch from 413d688 to c81ec5e Compare March 13, 2023 08:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.14 ⚠️

Comparison is base (72cbdf4) 56.56% compared to head (3d01ec8) 56.42%.

❗ Current head 3d01ec8 differs from pull request most recent head e43f68d. Consider uploading reports for the commit e43f68d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2138      +/-   ##
==========================================
- Coverage   56.56%   56.42%   -0.14%     
==========================================
  Files         313      313              
  Lines       33241    33245       +4     
==========================================
- Hits        18800    18756      -44     
- Misses      12213    12263      +50     
+ Partials     2228     2226       -2     
Flag Coverage Δ
cluster 45.08% <100.00%> (-0.17%) ⬇️
dm 26.27% <0.00%> (+0.04%) ⬆️
playground 15.27% <12.50%> (-<0.01%) ⬇️
tiup 15.93% <0.00%> (-0.03%) ⬇️
unittest 22.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/tiflash_config.go 50.00% <50.00%> (ø)
pkg/cluster/spec/tiflash.go 70.50% <100.00%> (-0.30%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hongyunyan
Copy link
Contributor Author

/run-integrate-cluster-cmd

@hongyunyan
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hongyunyan: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e43f68d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@ti-chi-bot ti-chi-bot merged commit cb852ef into pingcap:master Mar 14, 2023
@kaaaaaaang kaaaaaaang added this to the 1.12.0 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants