-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mark_cache_size default value of tiflash.toml after v5.4.0 #2138
Remove mark_cache_size default value of tiflash.toml after v5.4.0 #2138
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
413d688
to
c81ec5e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
- Coverage 56.56% 56.42% -0.14%
==========================================
Files 313 313
Lines 33241 33245 +4
==========================================
- Hits 18800 18756 -44
- Misses 12213 12263 +50
+ Partials 2228 2226 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
/run-integrate-cluster-cmd |
/merge |
@hongyunyan: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e43f68d
|
What problem does this PR solve?
ref pingcap/tiflash#6861
What is changed and how it works?
Remove mark_cache_size default value of tiflash.toml after v5.4.0
Because tiflash add default_mark_cache_size = 5G in code from v5.4.0, so for the version after v5.4.0, we can directly remove this item in config.
Check List
Tests
use tiup-playground and tiup-cluster to start cluster in nightly and v5.3.0 to check the tiflash.toml
Code changes
Side effects
Related changes
Release notes: