Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: integrate tispark #531

Merged
merged 23 commits into from
Jul 17, 2020
Merged

cluster: integrate tispark #531

merged 23 commits into from
Jul 17, 2020

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Jun 24, 2020

What problem does this PR solve?

Add TiSpark support to cluster component, being able to deploy and manage a cluster with TiSpark as one of the components.

Close #348

What is changed and how it works?

  • Add topology and component specifications for TiSpark
  • Download packages as needed
  • Render configs and scripts for TiSpark from template and specs
  • Deploy necessary files to server
  • Start/Stop tispark nodes
  • Scale out of TiSpark nodes
  • Handling upgrade process of TiSpark nodes
  • Destroy / scale in of TiSpark nodes
  • UI adjustment and testing 🚧
  • Add documentation 🚧
  • Import TiSpark nodes from TiDB-Ansible (will be done in another PR)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to update the documentation

@AstroProfundis AstroProfundis added type/new-feature Categorizes pr as related to a new feature. status/WIP labels Jun 24, 2020
@AstroProfundis AstroProfundis self-assigned this Jun 24, 2020
@lucklove lucklove added this to the v1.1.0 milestone Jun 28, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2020

Codecov Report

Merging #531 into master will increase coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   50.73%   51.38%   +0.65%     
==========================================
  Files         220      225       +5     
  Lines       16102    16559     +457     
==========================================
+ Hits         8169     8509     +340     
- Misses       6787     6864      +77     
- Partials     1146     1186      +40     
Flag Coverage Δ
#coverage 51.38% <ø> (+0.65%) ⬆️
Impacted Files Coverage Δ
.../pingcap/tiup/components/cluster/command/reload.go 60.86% <0.00%> (-5.80%) ⬇️
...ingcap/tiup/components/cluster/command/scale_in.go 58.58% <0.00%> (-5.16%) ⬇️
.../pingcap/tiup/components/playground/utils/utils.go 27.65% <0.00%> (-4.26%) ⬇️
...thub.com/pingcap/tiup/pkg/cluster/spec/instance.go 75.36% <0.00%> (-2.60%) ⬇️
...pingcap/tiup/components/cluster/command/upgrade.go 68.50% <0.00%> (-1.77%) ⬇️
.../pingcap/tiup/components/cluster/command/deploy.go 77.13% <0.00%> (-0.38%) ⬇️
...ngcap/tiup/components/cluster/command/scale_out.go 64.50% <0.00%> (-0.26%) ⬇️
...c/github.com/pingcap/tiup/pkg/cluster/spec/util.go 69.23% <0.00%> (ø)
...ithub.com/pingcap/tiup/pkg/cluster/executor/ssh.go 65.43% <0.00%> (ø)
...om/pingcap/tiup/pkg/cluster/embed/autogen_pkger.go 100.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 716860a...0bf52f3. Read the comment docs.

@AstroProfundis AstroProfundis force-pushed the tispark branch 3 times, most recently from 29bbe45 to f6cec4a Compare July 2, 2020 12:10
@AstroProfundis AstroProfundis force-pushed the tispark branch 14 times, most recently from d8da6fc to 2c4f7a9 Compare July 10, 2020 06:59
@AstroProfundis AstroProfundis marked this pull request as ready for review July 10, 2020 07:40
@AstroProfundis AstroProfundis requested a review from lonng July 10, 2020 07:42
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 17, 2020
@lucklove lucklove merged commit 8a10556 into pingcap:master Jul 17, 2020
@AstroProfundis AstroProfundis deleted the tispark branch July 17, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/new-feature Categorizes pr as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TiSpark support
7 participants