Clone with yanked version #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucklove
added
type/new-feature
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 50.95% 50.94% -0.02%
==========================================
Files 219 219
Lines 15951 15970 +19
==========================================
+ Hits 8128 8136 +8
- Misses 6684 6687 +3
- Partials 1139 1147 +8
Continue to review full report at Codecov.
|
AstroProfundis
approved these changes
Jul 15, 2020
lonng
reviewed
Jul 15, 2020
| } | ||
|
|
||
| // VersionList return all versions exclude yanked versions | ||
| func (manifest *Component) VersionList(platform string) map[string]VersionItem { |
There was a problem hiding this comment.
I think public methods should well-tested.
|
This PR lack of testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time,
tiup mirror clone <dir> <version>will clone component manifest only contains .If we deployed a cluster with an early version, some commands may fail since we can't find the entry in the manifest.
This PR will clone the component manifest with all versions, the versions besides the target version will be set as
yanked